From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: fix link with gcc Date: Thu, 29 May 2014 08:48:39 +0200 Message-ID: <2352405.jTgRhv3zRV@xps13> References: <1401195316-31149-1-git-send-email-thomas.monjalon@6wind.com> <5385CCE8.6030501@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dev-VfR2kkLFssw@public.gmane.org To: Olivier MATZ Return-path: In-Reply-To: <5385CCE8.6030501-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Olivier, 2014-05-28 13:47, Olivier MATZ: > On 05/27/2014 02:55 PM, Thomas Monjalon wrote: > > Some linker options were not prefixed by -Wl, when using gcc: > > =09-z muldefs > > =09-melf_i386 (32-bit config) > >=20 > > Using macro linkerprefix is fixing it. > >=20 > > Signed-off-by: Thomas Monjalon >=20 > The patch looks correct, but from the commit log it's difficult > to understand what is the problem today. Is there a compilation > issue? Or is it just cleaning? You're right, title should be: =09mk: fix 32-bit link with gcc And I should add some details in the commit log: I didn't see any error with -z muldefs but it isn't documented in gcc m= anual.=20 So it's safer to explicitly pass it to the linker. The variable CPU_LDFLAGS contains "-melf_i386" in 32-bit configurations= . So=20 building 32-bit shared library raises this error: =09gcc: error: unrecognized command line option =E2=80=98-melf_i386=E2=80= =99 Olivier, I'll make these changes if you (or Neil) ack the patch. Thanks for review --=20 Thomas