From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] drivers/net: do not redefine bool
Date: Tue, 25 Sep 2018 11:04:17 +0200
Message-ID: <2353010.843Iz9OGFG@xps>
References: <20180920001853.23454-1-thomas@monjalon.net>
 <1920676.XclAJlGjTg@xps> <840d806c-d75c-f990-5883-1315ea37f95b@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Xiao Wang <xiao.w.wang@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Rasesh Mody <rasesh.mody@cavium.com>, Harish Patil <harish.patil@cavium.com>,
 Shahed Shaikh <shahed.shaikh@cavium.com>, Yong Wang <yongwang@vmware.com>,
 dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E7F174C9D
 for <dev@dpdk.org>; Tue, 25 Sep 2018 11:04:22 +0200 (CEST)
In-Reply-To: <840d806c-d75c-f990-5883-1315ea37f95b@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/09/2018 10:03, Ferruh Yigit:
> On 9/24/2018 5:59 PM, Thomas Monjalon wrote:
> >>> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> >>> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> >>> @@ -2025,7 +2025,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts,
> >>>  		struct ixgbe_rx_entry *next_rxe = NULL;
> >>>  		struct rte_mbuf *first_seg;
> >>>  		struct rte_mbuf *rxm;
> >>> -		struct rte_mbuf *nmb;
> >>> +		struct rte_mbuf *nmb = NULL;
> >>
> >> This change is unrelated. Can we separate this one?
> > 
> > Yes it looks unrelated but it becomes necessary when including stdbool.h.
> > I don't know the root cause, but yes, it may deserve a separate commit.
> > Maybe an ixgbe maintainer can take care of it?
> 
> Why becomes necessary? Does it give a build warning etc?
> My concern is this is in data path, one extra assignment, it would be better to
> confirm it is really needed.

Yes I had a compilation error.
If you cannot reproduce it, I will try to re-run my compilation tests.