From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] arm64: change rte_memcpy to inline function Date: Fri, 13 May 2016 17:49:53 +0200 Message-ID: <2364439.Jm7BSl6O9C@xps13> References: <1462869064-9423-1-git-send-email-jianbo.liu@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com To: Jianbo Liu Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id A45568DB1 for ; Fri, 13 May 2016 17:49:55 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id g17so37086402wme.1 for ; Fri, 13 May 2016 08:49:55 -0700 (PDT) In-Reply-To: <1462869064-9423-1-git-send-email-jianbo.liu@linaro.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-05-10 14:01, Jianbo Liu: > Other APP may call rte_memcpy by function pointer, > so change it to an inline function. Any example in mind? > --- a/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h > +++ b/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h > -#define rte_memcpy(d, s, n) memcpy((d), (s), (n)) > +static inline void * > +rte_memcpy(void *dst, const void *src, size_t n) > +{ > + return memcpy(dst, src, n); > +} It has no sense if other archs (arm32, ppc64, tile) are not updated.