From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] eal: disable IOVA mode detection by default
Date: Wed, 1 Nov 2017 11:31:34 -0700
Message-ID: <236c9e59-c43f-7503-343a-fe05824fa2d7@intel.com>
References: <20171101010726.17781-1-ferruh.yigit@intel.com>
 <20171101040251.GA13569@jerin>
 <80719d01-7859-e6ac-ee1e-964a04357098@intel.com>
 <20171101065431.GA25152@jerin>
 <d6755d4c-a60a-c50d-1b0b-647b73d2c87d@intel.com>
 <20171101082642.GA30967@jerin>
 <ED26CBA2FAD1BF48A8719AEF02201E36513391C6@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>,
 Santosh Shukla <santosh.shukla@caviumnetworks.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 53E181B2F5
 for <dev@dpdk.org>; Wed,  1 Nov 2017 19:31:37 +0100 (CET)
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E36513391C6@SHSMSX103.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/1/2017 1:53 AM, Tan, Jianfeng wrote:
> 
> 
>> -----Original Message-----
> ...
>>>
>>>> Regarding the KNI crash, it can be avoid by first checking the exiting
>>>> mode(rte_eal_iova_mode()). i.e since legacy driver like KNI need real
>>>> physical address to work "now", it can grace full exit on the init time if
>>>> mode == IOVA_VA;
>>>
>>> For the KNI crash, do we really need to correct the case:  make those PMDs
>>> (requires IOVA_VA)  also work well with KNI?
>>> - If no, we just need to report  RTE_PCI_DRV_IOVA_AS_VA smartly.
>>> - If yes, we shall make KNI work with VA.
>>
>> I would say "yes". But for this immediate release, I would say "no".
> 
> Ferruh, if you also agree on "no" for now, we might fix it like this:

I agree with Jerin, for this release "no", for long term "yes".

> 
> For PMDs like ixgbe/i40e/..., we detect if phys_addrs_available to decide RTE_PCI_DRV_IOVA_AS_VA in a RTE_INIT function.
> 
> How do you think of that?

Instead Santosh's suggestion looks simpler.
Detect if kni module inserted, if so set IOVA PA mode.

I guess rte_bus_get_iommu_class() can updated for this check as workaround.

> 
> Thanks,
> Jianfeng
>