From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] kni: bug fix of compiling KNI kernel module on Linux kernel 3.6.10 Date: Tue, 20 May 2014 11:16:05 +0200 Message-ID: <23739506.Drt1PRsGzO@xps13> References: <1400422458-16322-1-git-send-email-helin.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: HELIN ZHANG Return-path: In-Reply-To: <1400422458-16322-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-05-18 22:14, HELIN ZHANG: > Error of "implicit-function-declaration" can be seen when building > KNI kernel module on Linux kernel 3.6.10 platform. Please show the error message in the commit log. > The root cause is as follows. > On Linux kernel 3.6.10, ETHTOOL_GEEE is defined in Linux header file > of "linux/ethtool.h", while is not defined in most of other > linux kernel versions. > mmd_eee_cap_to_ethtool_sup_t(), mmd_eee_adv_to_ethtool_adv_t() and > ethtool_adv_to_mmd_eee_adv_t() in kcompat.h are disabled by > "#if !defined(ETHTOOL_GEEE) || (RHEL_RELEASE_CODE && RHEL_RELEASE_CODE > <= RHEL_RELEASE_VERSION(6,4))", while are called in igb_get_eee() > in igb_ethtool.c which is enabled by "#ifdef ETHTOOL_GEEE". The title is about Linux 3.6.10 but is seems more related to a RedHat version. Could you fix title and commit log, please? Is it related to this error? http://dpdk.org/ml/archives/dev/2014-May/002457.html Neil made an interesting comment about it: http://dpdk.org/ml/archives/dev/2014-May/002351.html Thanks -- Thomas