From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 07/24] rte_spinlock.h: stack declarations before code Date: Sun, 13 May 2018 22:42:09 +0200 Message-ID: <2375295.AOUgtt1Tih@xps> References: <152609021699.121661.5295227351721865436.stgit@localhost.localdomain> <152609035743.121661.16417462726686469432.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, stable@dpdk.org To: Andy Green Return-path: In-Reply-To: <152609035743.121661.16417462726686469432.stgit@localhost.localdomain> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/05/2018 03:59, Andy Green: > /projects/lagopus/src/dpdk/build/include/rte_spinlock.h: > In function 'rte_try_tm': > /projects/lagopus/src/dpdk/build/include/rte_spinlock.h:82:2: > warning: ISO C90 forbids mixed declarations and code > [-Wdeclaration-after-statement] > int retries = RTE_RTM_MAX_RETRIES; Fixes: ba7468997ea6 ("spinlock: add HTM lock elision for x86") Cc: stable@dpdk.org > Signed-off-by: Andy Green Applied, thanks