From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] eal/service: improve error checking of
	coremasks
Date: Thu, 26 Jul 2018 16:18:11 +0200
Message-ID: <2376975.KA9Fdbqaqj@xps>
References: <1526399782-156061-1-git-send-email-harry.van.haaren@intel.com>
 <1531502739-121073-1-git-send-email-harry.van.haaren@intel.com>
 <2874140.BQP81VYxLs@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, vipin.varghese@intel.com
To: Harry van Haaren <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0859D3238
 for <dev@dpdk.org>; Thu, 26 Jul 2018 16:18:16 +0200 (CEST)
In-Reply-To: <2874140.BQP81VYxLs@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Harry,

Are you OK to make a v4?


13/07/2018 19:33, Thomas Monjalon:
> 13/07/2018 19:25, Harry van Haaren:
> > v3:
> > - Use WARNING instead of ERR log level (Vipin)
> > - Put strings on one line for grep-ability (Harry)
> 
> We can consider it is OK to have sentences on different lines.
> Who is grepping 2 sentences at once?
> 
> > v2, thanks for review:
> > - Consistency in message endings - vs . (Thomas)
> 
> Some dots are missing.
> 
> > - Wrap lines as they're very long otherwise (Thomas)
> 
> Lines are not wrapped.
> 
> > +		RTE_LOG(WARNING, EAL,
> > +			"Service cores parsed before dataplane cores Please ensure -c is before -s or -S.\n");
> 
> I think this would be better:
> 
> 		RTE_LOG(WARNING, EAL,
> 			"Service cores parsed before dataplane cores. "
> 			"Please ensure -c is before -s or -S.\n");