From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v9 3/5] test: add unit tests for latencystats
	library
Date: Tue, 31 Jul 2018 19:05:37 +0200
Message-ID: <2377661.dBTvqWlEOu@xps>
References: <1533055256-10317-1-git-send-email-reshma.pattan@intel.com>
 <1533055256-10317-4-git-send-email-reshma.pattan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, anatoly.burakov@intel.com, jananeex.m.parthasarathy@intel.com
To: Reshma Pattan <reshma.pattan@intel.com>,
 Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 008A637AF
 for <dev@dpdk.org>; Tue, 31 Jul 2018 19:05:43 +0200 (CEST)
In-Reply-To: <1533055256-10317-4-git-send-email-reshma.pattan@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

31/07/2018 18:40, Reshma Pattan:
> From: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
> 
> Unit Test Cases added for latencystats library.
> 
> Signed-off-by: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> ---

Compilation error with clang:

> +	struct rte_metric_name names[NUM_STATS] = { 0 };

test_latencystats.c:73:46: fatal error:
suggest braces around initialization of subobject [-Wmissing-braces]

> +	struct rte_metric_name wrongnames[NUM_STATS - 2] = { 0 };

Usually, it is recommended to use memset for initializations of structs.