From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re:
	=?utf-8?q?=5BPATCH_3/3_v2=5D_librte=5Feal/common=3A_Fi?=
	=?utf-8?q?x_redeclaration_of_enumerator_=E2=80=98REG=5FEAX?=
	=?utf-8?b?4oCZ?=
Date: Thu, 05 Mar 2015 15:38:56 +0100
Message-ID: <2382780.BfG7EQavsa@xps13>
References: <1425561339-13300-4-git-send-email-michael.qiu@intel.com>
 <CALwxeUsEMNyi7Bwgmr80=cOgxFw2fJh=rdO0hbErpFec_98QLA@mail.gmail.com>
 <533710CFB86FA344BFBF2D6802E60286CEEF6B@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Qiu, Michael" <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CEEF6B-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2015-03-05 14:03, Qiu, Michael:
> On 3/5/2015 9:54 PM, David Marchand wrote:
> > On Thu, Mar 5, 2015 at 2:50 PM, Michael Qiu <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
> > <mailto:michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>> wrote:
> >
> >     include/rte_cpuflags.h:154:2: error: redeclaration of enumerato=
r
> >     =E2=80=98REG_EAX=E2=80=99
> >     In file included from /usr/include/signal.h:358:0,
> >                      from /usr/include/sys/wait.h:30,
> >                      from /root/dpdk/app/test/test_mp_secondary.c:5=
0:
> >     /usr/include/sys/ucontext.h:180:3: note: previous definition of=

> >     =E2=80=98REG_EAX=E2=80=99 was here
> >
> >     In i686, from REG_EAX to REG_EDX are all defined in
> >             /usr/include/sys/ucontext.h
> >
> >     Rename to CPU_REG_EAX to avoid this issue.
> >
> >     Signed-off-by: Michael Qou <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
> >     <mailto:michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>>
> >
> >
> > NAK.
> >
>=20
> I have answered in you last thread, please check the mail.
>=20
> Yes, but for some reason, it was not include, see /usr/include/signal=
.h:358
>=20
> # include <bits/sigstack.h>
> # if defined __USE_XOPEN || defined __USE_XOPEN2K8
> /* This will define `ucontext_t' and `mcontext_t'.  */
> #  include <sys/ucontext.h>
> # endif
>=20
> So only if __USE_XOPEN or __USE_XOPEN2K8 been defined will include=20=

> <sys/ucontext.h>

So try to define USE_XOPEN.

> Why NAK?

Because it seems you didn't really try to include system headers.
We must avoid redefine existing symbols. That's why this bug happens.
Michael, thanks for trying to fix this issue. It's appreciated even if
the first solution is refused.