From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] doc: add new targets to "make help" output
Date: Fri, 04 Aug 2017 00:50:24 +0200
Message-ID: <2383964.bQBCqqHOqo@xps>
References: <1496699017-98327-1-git-send-email-erik.g.carrillo@intel.com>
 <1499447399-9467-1-git-send-email-erik.g.carrillo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Gabriel Carrillo <erik.g.carrillo@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1F7CF2C16
 for <dev@dpdk.org>; Fri,  4 Aug 2017 00:50:26 +0200 (CEST)
In-Reply-To: <1499447399-9467-1-git-send-email-erik.g.carrillo@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

Sorry for the very very late review.

07/07/2017 19:09, Gabriel Carrillo:
> Commit aafaea3d3b70 ("devtools: add tags
> and cscope index generation") introduced
> new make targets. This change updates the
> help target output to reflect the additions.
> 
> Signed-off-by: Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> +	tags|gtags T=    generate tags/gtags for given targets (T=)
> +	cscope T=        generate cscope database for given targets (T=)

No need of T= in the first column.
It is specified only for install which has two different meanings
with and without T=.

You should also add etags I think.