From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] devtools: check wrong svg include in patches
Date: Wed, 31 Oct 2018 16:51:28 +0100
Message-ID: <2386985.QZ5W8hjx9Q@xps>
References: <20181031110548.31184-1-thomas@monjalon.net>
 <CAKy9EB1D=92HkQ_LK+ZoLtCsCKNG60MnN6VAquXSs2OP+NU0xg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
To: Arnon Warshavsky <arnon@qwilt.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B4C1C239
 for <dev@dpdk.org>; Wed, 31 Oct 2018 16:51:25 +0100 (CET)
In-Reply-To: <CAKy9EB1D=92HkQ_LK+ZoLtCsCKNG60MnN6VAquXSs2OP+NU0xg@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Arnon,

31/10/2018 16:46, Arnon Warshavsky:
> Hi Thomas
> 
> Glad the function gets to be reused :)
> Now that it has more than one consumer apparently the function
> check_forbidden_additions() cannot be fed by stdin.
> I got it working with 3 changes:

Thanks for the help

> 1. call the awk script with $tmpinput as a parameter instead of stdin. This
> aligns with Neils changes from previous version
> 2. Escaped the spaces from the regex , as the awk script uses spaces to
> tell multiple forbidden expressions apart (which now I see sucks ...),
>     and added an extra backslash

Are you sure we need an extra backslash?
Note that I am using single quotes.
I thought we need only 2 backslashes in this case.

> 3. call the function with no parameters (not needed anymore)
> 
>         awk -v FOLDERS="lib drivers" \
>                 -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
>                 -v RET_ON_FAIL=1 \
> -               -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk -
> +               -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk
> *$tmpinput*
> +
> +       awk -v FOLDERS='doc' \
> +               -v EXPRESSIONS='*::[[:space:]]*[^[:space:]]*\\\.svg*' \
> +               -v RET_ON_FAIL=1 \
> +               -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk
> *$tmpinput*
> 
>         ! $verbose || printf '\nChecking forbidden tokens additions:\n'
> -       report=$(check_forbidden_additions *<"$tmpinput"*)
> +       report=$(check_forbidden_additions)