From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] net/mlx4: support CRC strip toggling Date: Mon, 26 Mar 2018 14:30:34 +0200 Message-ID: <2388926.RzC4zprzFL@xps> References: <1521477410-8936-1-git-send-email-ophirmu@mellanox.com> <20180326115452.GF4011@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ferruh Yigit , Ophir Munk , dev@dpdk.org, Olga Shern , Shahaf shuler To: Adrien Mazarguil Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 8F80634F0 for ; Mon, 26 Mar 2018 14:30:36 +0200 (CEST) In-Reply-To: <20180326115452.GF4011@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/03/2018 13:54, Adrien Mazarguil: > On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: > > On 3/25/2018 9:19 PM, Ophir Munk wrote: > > > Previous to this commit mlx4 CRC stripping was executed by default and > > > there was no verbs API to disable it. > > > > Are you aware of the discussion about CRC [1]? Is this patch compatible with plans? > > > > [1] > > https://dpdk.org/dev/patchwork/patch/36415/ > > I wasn't aware of this notice. Looks like it makes this patch unnecessary > since mlx4 always strip by default; this patch makes it configurable at will > and only exposes the capability when HW supports its configuration (i.e. the > ability to leave CRC inside mbuf). > > We'd just need mlx4 to not expose DEV_RX_OFFLOAD_CRC_STRIP at all in > mlx5_get_rx_queue_offloads() in order to fully comply. > > I leave it up to you, I don't mind if we include this patch only to revert > it later when we finally get rid of DEV_RX_OFFLOAD_CRC_STRIP. A new flag to keep CRC will be introduced. We will need toggling anyway.