From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus
	driver skeleton
Date: Tue, 19 Sep 2017 18:44:27 +0530
Message-ID: <2392e7d0-4790-9f1f-27b1-62b8fe775a87@nxp.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-3-shreyansh.jain@nxp.com>
 <be78a122-7c20-3c23-bfe0-181131de537a@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0054.outbound.protection.outlook.com [104.47.41.54])
 by dpdk.org (Postfix) with ESMTP id 988DB1AEF5
 for <dev@dpdk.org>; Tue, 19 Sep 2017 15:03:34 +0200 (CEST)
In-Reply-To: <be78a122-7c20-3c23-bfe0-181131de537a@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Ferruh,

On Monday 18 September 2017 08:17 PM, Ferruh Yigit wrote:
> On 9/9/2017 12:20 PM, Shreyansh Jain wrote:
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> <...>
> 
>> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map
>> new file mode 100644
>> index 0000000..d97a009
>> --- /dev/null
>> +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map
>> @@ -0,0 +1,7 @@
>> +DPDK_17.11 {
>> +	global:
>> +
>> +	rte_dpaa_driver_register;
>> +	rte_dpaa_driver_unregister;
> 
> "local *;" ?

Agree. I will change this.
Currently rte_dpaa_driver_* functions are being used locally within 
bus/dpaa.

> 
> <...>
> 
>> +struct rte_dpaa_device {
>> +	TAILQ_ENTRY(rte_dpaa_device) next;
>> +	struct rte_device device;
>> +	union {
>> +		struct rte_eth_dev *eth_dev;
>> +		struct rte_cryptodev *crypto_dev;
>> +	};
> 
> Bus struct should be independt from functionality, this has been done in
> PCI, can same thing be done for dpaa bus too?

Sorry, I didn't get your point. This is the rte_dpaa_bus structure:

struct rte_dpaa_bus {
         struct rte_bus bus;
         struct rte_dpaa_device_list device_list;
         struct rte_dpaa_driver_list driver_list;
         int device_count;
};

If you are referring to unlinking eth/crypto functionality from 
rte_dpaa_device - that is something which needs investigation. I have 
seen patches on PCI from Gaetan. Can that be an incremental change over 
this?

> 
> <...>
> 
>> + * @return
>> + *	0 in case of success, error otherwise
>> + */
>> +int rte_dpaa_portal_init(void *arg);
> 
> Definition is not in this patch.
> 
>> +
>> +/**
>> + * Cleanup a DPAA Portal
>> + */
>> +void dpaa_portal_finish(void *arg);
> 
> Definition is not in this patch.
> 
> <...>
> 

Yes, this is my mistake. I will fix this.