From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 14/15] net/vmxnet3: rename version map after
	library file name
Date: Fri, 14 Sep 2018 09:46:43 +0200
Message-ID: <2409775.xiy84CyIAu@xps>
References: <20180910200415.8340-1-bluca@debian.org>
 <20180910200415.8340-15-bluca@debian.org>
 <C7A3B202-963B-46BB-93B2-D3AFB406EDD7@vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Luca Boccassi <bluca@debian.org>, "dev@dpdk.org" <dev@dpdk.org>,
 "keith.wiles@intel.com" <keith.wiles@intel.com>,
 "roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>,
 "jingjing.wu@intel.com" <jingjing.wu@intel.com>,
 "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
 "rasesh.mody@cavium.com" <rasesh.mody@cavium.com>,
 "harish.patil@cavium.com" <harish.patil@cavium.com>,
 "shahed.shaikh@cavium.com" <shahed.shaikh@cavium.com>,
 "amr.mokhtar@intel.com" <amr.mokhtar@intel.com>,
 "shijith.thotton@cavium.com" <shijith.thotton@cavium.com>,
 "ssrinivasan@cavium.com" <ssrinivasan@cavium.com>,
 "liang.j.ma@intel.com" <liang.j.ma@intel.com>,
 "peter.mccarthy@intel.com" <peter.mccarthy@intel.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
 "maciej.czekaj@caviumnetworks.com" <maciej.czekaj@caviumnetworks.com>,
 "arybchenko@solarflare.com" <arybchenko@solarflare.com>,
 "a
To: Yong Wang <yongwang@vmware.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id AFD7B4CA6
 for <dev@dpdk.org>; Fri, 14 Sep 2018 09:46:51 +0200 (CEST)
In-Reply-To: <C7A3B202-963B-46BB-93B2-D3AFB406EDD7@vmware.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

13/09/2018 23:44, Yong Wang:
> From: Luca Boccassi <bluca@debian.org>
>     The library is called librte_pmd_vmxnet3_uio, so rename the map
>     file and set the name in the meson file so that the built library names
>     with meson and legacy makefiles are the same
>     
>     Signed-off-by: Luca Boccassi <bluca@debian.org>
>     ---
> 
> Not directly related to this change but I have some question on the uio naming.  The original motivation is from the following commit:
> 
> commit 1daf0aae7fd6b3bc38952e9817a1653c1258be66
> Author: Thomas Monjalon <thomas.monjalon@6wind.com>
> Date:   Fri Mar 21 13:52:17 2014 +0100
> 
>     vmxnet3: rename library
>     
>     In order to distinguish clearly this implementation from the extension
>     vmxnet3-usermap, it is renamed to reflect its usage of uio framework.
>     
>     Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>     Acked-by: Thomas Graf <tgraf@redhat.com>
> 
> However, this version of vmxnet3 can also be bound to vfio-pci driver.  I think having the uio naming in that case will be misleading. 

Yes, i agree.
vmxnet3-usermap is not maintained anymore, so we can remove the uio suffix.