From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ixgbe: restore imissed stat counter Date: Tue, 15 Dec 2015 18:06:24 +0100 Message-ID: <2411343.XAzfyo3F5c@xps13> References: <1450195501-9196-1-git-send-email-robin.jarry@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Robin Jarry Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 71E0BFE5 for ; Tue, 15 Dec 2015 18:07:41 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id n186so104887388wmn.0 for ; Tue, 15 Dec 2015 09:07:41 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-12-15 16:41, Van Haaren, Harry: > > From: Robin Jarry [mailto:robin.jarry@6wind.com] > > Subject: [PATCH] ixgbe: restore imissed stat counter > > > > This counter was left unmodified. Restore it in ixgbe_dev_stats_get. > > > > The ierrors counter still includes imissed for ixgbe. This behaviour is > > not consistent amongst all drivers. Another patch may be needed to unify > > the meaning of the ierrors counter. > > > > Fixes: 5e50ad1c1b63 ("ixgbe: add specific stats") > > > > Signed-off-by: Robin Jarry > > There is work to be done to allow easier distinction between > drops due to the host, and errors due to bad packets. > > Until that work is done, write the dropped packet count to imissed, so: > > Acked-by: Harry van Haaren Applied, thanks