From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 1/4] ethdev: separate driver APIs Date: Mon, 22 Jan 2018 00:12:47 +0100 Message-ID: <2413567.jYmEStPfnM@xps> References: <20180117215802.90809-1-ferruh.yigit@intel.com> <20180120165746.21209-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Ferruh Yigit Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id B4805A495 for ; Mon, 22 Jan 2018 00:13:25 +0100 (CET) In-Reply-To: <20180120165746.21209-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/01/2018 17:57, Ferruh Yigit: > Create a rte_ethdev_driver.h file and move PMD specific APIs here. > Drivers updated to include this new header file. > > There is no update in header content and since ethdev.h included by > ethdev_driver.h, nothing changed from driver point of view, only > logically grouping of APIs. From applications point of view they can't > access to driver specific APIs anymore and they shouldn't. > > More PMD specific data structures still remain in ethdev.h because of > inline functions in header use them. Those will be handled separately. > > Signed-off-by: Ferruh Yigit > Acked-by: Shreyansh Jain > Acked-by: Andrew Rybchenko It is really hard to review, especially patches 2 and 3. But I really like the idea, so Series Acked-by: Thomas Monjalon Let's take this change in 18.02-rc1.