From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: rename folder to library name Date: Tue, 03 Apr 2018 18:43:15 +0200 Message-ID: <24175442.FuofMSqENj@xps> References: <20180403092859.71589-1-ferruh.yigit@intel.com> <4D4592F2-7C34-489E-BBAD-A3E8422FD468@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: "Mcnamara, John" , "Kovacevic, Marko" , "dev@dpdk.org" , "Richardson, Bruce" To: Ferruh Yigit , "Wiles, Keith" Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 02D001B83B for ; Tue, 3 Apr 2018 18:44:20 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/04/2018 15:29, Ferruh Yigit: > On 4/3/2018 2:17 PM, Wiles, Keith wrote: > >> On Apr 3, 2018, at 4:28 AM, Ferruh Yigit wrot= e: > >> > >> Library folder name and output library name are same except a few flaws > >> including librte_ether. > >> > >> This library is network device abstraction layer, the name "ethdev" fi= ts > >> better than "ether", and library & header files already named as ethde= v. > >> > >> Also there is a rte_ether.h in the net library which can cause confusi= on. > >> > >> Signed-off-by: Ferruh Yigit > >> --- > >> Not sure if the we are ready for this change J > >> > >> This is one the issues that the hassle of the change doesn't worth the > >> benefit and you may prefer to live with the flaw. > >> > >> Also a concern is this breaks the git history. > >=20 > > I believe as long as you used =E2=80=98git mv=E2=80=99 the git history = should not be broken, correct? I think "git mv" does nothing special. Git tracks the content, so it is the same as using "mv + git add + git rm". > I think this will help in some conflict resolving or git blame, but if yo= u check > the history directly with path, it won't show the past: >=20 > "git log --oneline lib/librte_ethdev/": Will start from this commit You can use --follow. Unfortunately, it does not work well with gitk. You need to use a trick like https://stackoverflow.com/a/37375502 But there is no good solution when tracking a directory, like ethdev, which had a file split recently, and a directory rename.