From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring Date: Mon, 27 Feb 2017 14:48:58 +0100 Message-ID: <2417966.3G0haXHz4n@xps13> References: <20170123211340.22570-1-bmcfall@redhat.com> <20170127183800.27466-1-bmcfall@redhat.com> <20170127183800.27466-2-bmcfall@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: wenzhuo.lu@intel.com, olivier.matz@6wind.com, dev@dpdk.org To: Billy McFall Return-path: Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 85330591E for ; Mon, 27 Feb 2017 14:49:00 +0100 (CET) Received: by mail-wr0-f179.google.com with SMTP id u108so22651929wrb.3 for ; Mon, 27 Feb 2017 05:49:00 -0800 (PST) In-Reply-To: <20170127183800.27466-2-bmcfall@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-27 13:37, Billy McFall: > --- a/doc/guides/nics/features/default.ini > +++ b/doc/guides/nics/features/default.ini > @@ -55,6 +55,7 @@ FW version = > EEPROM dump = > Registers dump = > Multiprocess aware = > +Free TX ring buffers = I'm afraid this wording will be confusing, because every drivers free their buffers :) What about "Free Tx mbuf on demand" ? And please, move this line upper, just after "Rx interrupt". We also need to carefully review the doc you provided (thanks). First quick comment, please wrap lines shorter in the doc. About the function prototype, I've seen a double space :) I think you could use rte_errno (while keeping negative return codes).