From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 3/3] port: code clean-up Date: Fri, 01 Apr 2016 15:56:10 +0200 Message-ID: <2420426.ojDceOkhvu@xps13> References: <1459518117-23944-1-git-send-email-roy.fan.zhang@intel.com> <1459518117-23944-4-git-send-email-roy.fan.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Fan Zhang Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 6561F2B9C for ; Fri, 1 Apr 2016 15:58:06 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id f198so27240623wme.0 for ; Fri, 01 Apr 2016 06:58:06 -0700 (PDT) In-Reply-To: <1459518117-23944-4-git-send-email-roy.fan.zhang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-04-01 14:41, Fan Zhang: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -92,9 +92,7 @@ endif > ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n) > _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lfuse > endif > -ifeq ($(CONFIG_RTE_NEXT_ABI),y) > _LDLIBS-$(CONFIG_RTE_PORT_PCAP) += -lpcap > -endif Why removing NEXT_ABI here? The pcap port cannot work without it because of +#ifdef RTE_NEXT_ABI + + /** The full path of the pcap file to read packets from */ + char *file_name; + /** The number of bytes to be read from each packet in the + * pcap file. If this value is 0, the whole packet is read; + * if it is bigger than packet size, the generated packets + * will contain the whole packet */ + uint32_t n_bytes_per_pkt; + +#endif