From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: add notice for planned name size change Date: Tue, 08 Aug 2017 11:47:02 +0200 Message-ID: <24236398.BWkRJ1PWcL@xps> References: <20170706150751.27251-1-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Shahaf Shuler , Yongseok Koh To: Stephen Hemminger Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 141D12986 for ; Tue, 8 Aug 2017 11:47:25 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > VMBUS support will use GUID in eth_dev_data name field which requires > > > at least 37 characters. Plan for increase in size now. > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > > +* ethdev: An ABI change is planned for 17.11 for the structure > > eth_dev_data. > > Isn't it better to use "``rte_eth_dev_data``"? > > > > > + The size of the unique name will increase RTE_ETH_NAME_MAX_LEN > > from > > > + 32 to > > > + 64 characters to allow using a globally unique identifier (GUID) in this > > field. > > > > Except for the small comment above, > > Acked-by: Yongseok Koh > > Acked-by: Shahaf Shuler Acked-by: Thomas Monjalon Applied, thanks