From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCHv3 3/3] ABI: Add some documentation
Date: Fri, 26 Jun 2015 15:00:17 +0200
Message-ID: <2425730.LWzQFRnlUA@xps13>
References: <1435088014-18973-1-git-send-email-nhorman@tuxdriver.com>
 <1435242949-31520-1-git-send-email-nhorman@tuxdriver.com>
 <1435242949-31520-3-git-send-email-nhorman@tuxdriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Neil Horman <nhorman@tuxdriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id BBE08C8C6
 for <dev@dpdk.org>; Fri, 26 Jun 2015 15:01:23 +0200 (CEST)
Received: by wicnd19 with SMTP id nd19so17085649wic.1
 for <dev@dpdk.org>; Fri, 26 Jun 2015 06:01:23 -0700 (PDT)
In-Reply-To: <1435242949-31520-3-git-send-email-nhorman@tuxdriver.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-06-25 10:35, Neil Horman:
> v3)
>      * Fixed in tact -> intact
>      * Added docs to address static linking
>      * Removed duplicate documentation from release notes

It seems you missed some of my previous comments.

[...]
> +* ``VERSION_SYMBOL(b, e, n)``: Creates a symbol version table entry binding
> +  unversioned symbol ``b`` to the internal function ``b_e``.

Should a versioned symbol <b>@DPDK_<n>

> +* ``BASE_SYMBOL(b, e)``: Creates a symbol version table entry binding
> +  unversioned symbol ``b`` to the internal function ``b_e``.

Please give a use case of BASE_SYMBOL.

[...]
> +The addition of the new block tells the linker that a new version node is
> +available (DPDK_2.1), which contains the symbol rte_acl_create, and inherits the
> +symbols from the DPDK_2.0 node.

which contains the old version of the symbol rte_acl_create