From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 10/11] config: Enable BNX2X driver build by default Date: Thu, 03 Dec 2015 02:30:23 +0100 Message-ID: <2436122.zBamVnyWNt@xps13> References: <1448351076-23161-1-git-send-email-rasesh.mody@qlogic.com> <1740319.2UiCSnWV9s@xps13> <2552F74A0BCCBE4DBE2AD218C81B28110864B591@avmb3.qlogic.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Sony Chacko To: Rasesh Mody Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 1AC4958DB for ; Thu, 3 Dec 2015 02:31:34 +0100 (CET) Received: by wmuu63 with SMTP id u63so2228776wmu.0 for ; Wed, 02 Dec 2015 17:31:34 -0800 (PST) In-Reply-To: <2552F74A0BCCBE4DBE2AD218C81B28110864B591@avmb3.qlogic.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-12-03 00:54, Rasesh Mody: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Tuesday, November 24, 2015 6:26 AM > > > > We still have a compilation error when zlib.h is missing. > > Please keep it disabled until we have a solution (probably a "configure" > > script). > > Just to clarify - are you planning to have a generic ./configure script that would address external dependencies like zlib or are you proposing that we provide the configure script specific to bnx2x PMD? There will be a configure script in the next release. It will handle every dependencies. > Another option could be to not to include "bnx2x" if zlib.h header is not found by having a check in drivers/net/Makefile? How do you find zlib.h? It seems to be a job for gcc in a configure script.