From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 04/16] Make igb_uio compilation optional
Date: Tue, 27 May 2014 10:57:30 +0200
Message-ID: <2436275.7LybpPuKnj@xps13>
References: <DF2A19295B96364286FEB7F3DDA27A46F69410@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Xu, HuilongX" <huilongx.xu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <DF2A19295B96364286FEB7F3DDA27A46F69410-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi HuilongX,
(sorry, my previous email was sent before I finished writing it)

Thanks for testing patches.

In order to be more efficient next times, I have few comments.

2014-05-27 02:43, Xu, HuilongX:
> Currently, igb_uio is always compiled. Some Linux distribution may
> not want to include igb_uio by default, so we need to make sure that
> igb_uio compilation can be optional.

1) When replying to an email, there should be "> " in front of lines you have 
not written. Here, it's not easy to see what you are replying.

> Signed-off-by: Anatoly Burakov
> <anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org<mailto:anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>>

2) Your mailer is breaking the Signed-off line.

> Test-by: HuilongX Xu <huilongx.xu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org<mailto:huilongx.xu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>>

3) If you do some tests (other than compiling), you should explain what are 
the tests (command lines and environment).

> Compile pass

4) No need to notify that compilation is working. It's implicit (and 
mandatory) when sending a patch.

>      >>Compile OS: FC20 x86_64
>      >>Kernel version: 3.13.6-200
>      >>GCC version: 4.8.2
>      >>Server: Crownpass
> 
> ---
> config/defconfig_i686-default-linuxapp-gcc   |    1 +
> config/defconfig_i686-default-linuxapp-icc   |    1 +
> config/defconfig_x86_64-default-linuxapp-gcc |    1 +
> config/defconfig_x86_64-default-linuxapp-icc |    1 +
> lib/librte_eal/linuxapp/Makefile             |    2 ++
> lib/librte_eal/linuxapp/eal/eal_pci.c        |    2 +-
> 6 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/config/defconfig_i686-default-linuxapp-gcc
> b/config/defconfig_i686-default-linuxapp-gcc index 14bd3d1..ea90f12 100644
> --- a/config/defconfig_i686-default-linuxapp-gcc
> +++ b/config/defconfig_i686-default-linuxapp-gcc

5) Please do not copy all the patch if you have nothing specific to say about 
it.

Thanks for your help
-- 
Thomas