From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] igb_uio: fix vmware e1000 input/output error
Date: Mon, 21 Mar 2016 11:07:56 +0100
Message-ID: <2437286.FLD0q4sve1@xps13>
References: <1458550874-15709-1-git-send-email-qian.q.xu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, stephen@networkplumber.org
To: Qian Xu <qian.q.xu@intel.com>, Masaru OKI <m-oki@stratosphere.co.jp>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 11E5C2C09
 for <dev@dpdk.org>; Mon, 21 Mar 2016 11:09:34 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id r129so43390351wmr.1
 for <dev@dpdk.org>; Mon, 21 Mar 2016 03:09:34 -0700 (PDT)
In-Reply-To: <1458550874-15709-1-git-send-email-qian.q.xu@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-21 17:01, Qian Xu:
> INTX is badly emulated in Vmware, INTX toggle check didn't work
> with Vmware e1000 device. The patch is to fix the issue.

Is it possible to detect a VMware e1000 device?

> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>  	case RTE_INTR_MODE_LEGACY:
> -		if (pci_intx_mask_supported(dev)) {
> -			dev_dbg(&dev->dev, "using INTX");
> -			udev->info.irq_flags = IRQF_SHARED;
> -			udev->info.irq = dev->irq;
> -			udev->mode = RTE_INTR_MODE_LEGACY;
> -			break;
> -		}
> -		dev_notice(&dev->dev, "PCI INTX mask not supported\n");
> +                dev_dbg(&dev->dev, "using INTX");
> +                udev->info.irq_flags = IRQF_SHARED;
> +                udev->info.irq = dev->irq;
> +                udev->mode = RTE_INTR_MODE_LEGACY;
> +                break;
>  		/* fall back to no IRQ */
>  	case RTE_INTR_MODE_NONE:

This patch is removing the INTX support detection and the
fallback to no IRQ.