From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] pci: Add the class_id support in pci probe
Date: Thu, 19 May 2016 14:57:17 +0200
Message-ID: <243965117.o52RgkbZZP@xps13>
References: <1462946895-49958-1-git-send-email-ziye.yang@intel.com>
 <1727235.C3RSOGSy8E@xps13>
 <FA6C2217B01E9D48A581BB486602101401758FC6@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Yang, Ziye" <ziye.yang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id E26D69606
 for <dev@dpdk.org>; Thu, 19 May 2016 14:57:28 +0200 (CEST)
Received: by mail-wm0-f42.google.com with SMTP id a17so124897905wme.0
 for <dev@dpdk.org>; Thu, 19 May 2016 05:57:28 -0700 (PDT)
In-Reply-To: <FA6C2217B01E9D48A581BB486602101401758FC6@shsmsx102.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-05-19 12:18, Yang, Ziye:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] 
> 2016-05-11 14:08, Ziye Yang:
> > +	dev->id.class_id = (uint32_t)tmp && CLASS_ANY_ID;
> 
> Should be a bitwise &. Why masking is needed?
> [Ziye]  Only 24bit info is needed.

What are the other bits?
Please put a comment in the code.