From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1] doc: Merge l3fwd and l3fwd-acl documentation files Date: Sun, 07 May 2017 22:50:17 +0200 Message-ID: <2449201.3f6kNIuhA3@xps> References: <1493145557-17160-1-git-send-email-rkerur@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, konstantin.ananyev@intel.com To: Ravi Kerur Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 58B4D1F5 for ; Sun, 7 May 2017 22:50:19 +0200 (CEST) In-Reply-To: <1493145557-17160-1-git-send-email-rkerur@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 25/04/2017 20:39, Ravi Kerur: > Merge relevant contents of l3fwd and l3fwd-acl documentation. > Modify l3fwd document with ACL specific information. > Remove l3fwd-acl documentation file. > > Signed-off-by: Ravi Kerur > --- > doc/guides/sample_app_ug/img/ipv4_hash_rule.svg | 158 +++++++++ > doc/guides/sample_app_ug/img/ipv4_lpm_rule.svg | 139 ++++++++ > doc/guides/sample_app_ug/index.rst | 1 - > doc/guides/sample_app_ug/l3_forward.rst | 326 ++++++++++++++++- > .../sample_app_ug/l3_forward_access_ctrl.rst | 385 --------------------- > 5 files changed, 614 insertions(+), 395 deletions(-) > create mode 100644 doc/guides/sample_app_ug/img/ipv4_hash_rule.svg > create mode 100644 doc/guides/sample_app_ug/img/ipv4_lpm_rule.svg > delete mode 100644 doc/guides/sample_app_ug/l3_forward_access_ctrl.rst I've not looked at the content. I just do not understand why a patch for merging content is adding some new files. Moreover, these SVG files contains some binary PNG. Please send only some source files.