From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v9 00/12] Clean up pci uio implementations Date: Wed, 08 Jul 2015 23:52:18 +0200 Message-ID: <2456354.fItLHJVCy0@xps13> References: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp> <1436351693-2349-1-git-send-email-mukawa@igel.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit To: dev@dpdk.org, Tetsuya Mukawa Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id CEF9A5A57 for ; Wed, 8 Jul 2015 23:53:24 +0200 (CEST) Received: by wibdq8 with SMTP id dq8so225199051wib.1 for ; Wed, 08 Jul 2015 14:53:24 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Currently Linux implementation and BSD implementation have almost same > > code about pci uio. This patch series cleans up it. > > > > PATCH v9 changes: > > - Add lost Acked-by and Tested-by signatures. > > - Remove NULL checkings before calling rte_free(). > > - Fix pci_uio_map_secondary() to remove needless close(). > > - Remove needless parameter checkings of pci_uio_alloc_resource() and > > pci_uio_map_resource_by_index(). > > - Remove needless error checking for return value of > > pci_uio_alloc_resource(). > > - Introduce pci_uio_free_resource(). > > - Remove some comments of pci_uio_map_resource(). > > (Thanks to David Marchand) > > > Acked-by: David Marchand Applied, thanks The copyright additions were removed because not appropriate in a cleanup.