From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1] bus/fslmc: fix find device start condition Date: Thu, 05 Apr 2018 00:46:43 +0200 Message-ID: <24575642.k2hPTVmtYA@xps> References: <20180322102844.8109-1-gaetan.rivet@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Shreyansh Jain , stable@dpdk.org, Hemant Agrawal To: Gaetan Rivet Return-path: In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/03/2018 09:52, Shreyansh Jain: > On Thu, Mar 22, 2018 at 3:58 PM, Gaetan Rivet wrote: > > If start is set and a device before it matches the data, > > this device is returned. > > > > Fixes: c7fe1eea8a74 ("bus: simplify finding starting point") > > Cc: stable@dpdk.org > > > > Cc: Hemant Agrawal > > Cc: Shreyansh Jain > > Signed-off-by: Gaetan Rivet > > --- > > > > Hi Shreyansh, Hemant, > > > > Sorry, I did not test this. > > I found this issue while working on vdev and PCI. > > > > There is a better way to iterate on devices [1], but the gain > > is really minimal and the implementation slightly more complex. > > I preferred to avoid complex, as I could not test this patch. > > > > Regards, > > > > [1]: http://dpdk.org/ml/archives/dev/2018-March/092906.html > > > > I think this change should suffice here. Thanks. > > (On a side note, it seems compilation using clang is failing for this > patch [1] though it is not related to this change. I will look into > that) > > [1] http://dpdk.org/ml/archives/test-report/2018-March/044684.html > > Acked-by: Shreyansh Jain Applied, thanks