From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 0/2] lib: move Netlink wrapper to lib
Date: Thu, 15 Mar 2018 16:39:46 +0100
Message-ID: <2460477.86ImKqUlBA@xps>
References: <cover.1520943890.git.nelio.laranjeiro@6wind.com>
 <20180314120855.avapkwbwx6hecwmw@laranjeiro-vm.dev.6wind.com>
 <20180314081736.6b06dd2f@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Pascal Mazon <pascal.mazon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
 =?ISO-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 14DF944C7
 for <dev@dpdk.org>; Thu, 15 Mar 2018 16:47:39 +0100 (CET)
In-Reply-To: <20180314081736.6b06dd2f@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/03/2018 16:17, Stephen Hemminger:
> On Wed, 14 Mar 2018 13:08:55 +0100
> N=E9lio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
> > On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote:
> > > On Tue, 13 Mar 2018 13:28:25 +0100
> > > Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
> > > >  drivers/net/tap/Makefile                           |   3 +-
> > > >  drivers/net/tap/rte_eth_tap.c                      |  16 +--
> > > >  drivers/net/tap/tap_flow.c                         | 118 +++++++++=
+-----------
> > > >  drivers/net/tap/tap_netlink.h                      |  42 --------
> > > >  drivers/net/tap/tap_tcmsgs.c                       |  28 ++---
> > > >  drivers/net/tap/tap_tcmsgs.h                       |   2 +-
> > > >  lib/Makefile                                       |   2 +
> > > >  lib/librte_netlink/Makefile                        |  26 +++++
> > > >  lib/librte_netlink/meson.build                     |  13 +++
> > > >  .../librte_netlink/rte_netlink.c                   |  87 +++++++++=
++----
> > > >  lib/librte_netlink/rte_netlink.h                   |  43 ++++++++
> > > >  lib/librte_netlink/rte_netlink_version.map         |  18 ++++
> > >=20
> > > I might have raised this before; but having yet another netlink libra=
ry is
> > > not a great advantage. It would be much better to use a common extern=
al library
> > > libmnl which is already available on every distribution. =20
> >=20
> > The question is more do we really want to have a dependency on a so
> > small wrapper for a socket interface?
>=20
> Lots of drivers already have dependencies.
> And I trust libmnl rather than a reinvented library.

Are we sure it is commonly installed in distributions?

This is needed only for TAP and mlx drivers.
Do we really want to add this dependency as mandatory for everybody
to compile DPDK with default PMDs?

I see 4 options:
1/ keep duplicated few functions in PMDs
2/ use libmnl
3/ add the functions in a DPDK lib (this patch)
4/ add the functions in EAL

I would vote for the first option because mlx5 has very minimal
requirement regarding netlink.
The first option can give us some time to think about the right way
to use netlink in the next releases.