From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 0/2] Fix CRC32c computation Date: Tue, 01 Mar 2016 14:31:33 +0100 Message-ID: <2476239.BEsYoxOLBe@xps13> References: <1455010467-4991-1-git-send-email-didier.pallard@6wind.com> <1455879631-18420-1-git-send-email-didier.pallard@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Didier Pallard Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 1E5FE9ACF for ; Tue, 1 Mar 2016 14:33:09 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id l68so33555499wml.1 for ; Tue, 01 Mar 2016 05:33:09 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > CRC32c computation is not valid when buffer length is not a multiple of 4 > > bytes. > > Values returned by rte_hash_crc functions does not match the one > > computed by a trivial crc32c implementation. > > > > First patch fixes crc hash function autotests, to outline the problem. > > Second patch fixes CRC32c computation. > > > > Didier Pallard (2): > > test: fix CRC hash function autotest > > hash: fix CRC32c computation > > Series-acked-by: Pablo de Lara > > Not sure if you need to include a "Fixes" line in the commit messages. > In the first commit, probably you should, the commit that you are fixing is > 6298d2c55ae8 ("app/test: add new functional tests for hash functions"). Thanks > In the second commit, it is a bit more difficult, as we don't know that the commit is, > that code was integrated a while ago, before 1.2.3, which is the first public release in dpdk.org. Yes it helps to know the bug was there since the beginning. > Also, there is a typo "lengthes", in both commit messages. > > You can leave the ack in both patches. Thanks!! Applied, thanks