From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 03/14] ring: eliminate duplication of size and mask fields Date: Mon, 27 Mar 2017 11:52:58 +0200 Message-ID: <2476675.J1ds0gYDs0@xps13> References: <20170307113217.11077-1-bruce.richardson@intel.com> <20170324171008.29355-1-bruce.richardson@intel.com> <20170324171008.29355-4-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: olivier.matz@6wind.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com To: Bruce Richardson Return-path: Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id D5165FA57 for ; Mon, 27 Mar 2017 11:52:59 +0200 (CEST) Received: by mail-wr0-f178.google.com with SMTP id l43so47933374wre.1 for ; Mon, 27 Mar 2017 02:52:59 -0700 (PDT) In-Reply-To: <20170324171008.29355-4-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-24 17:09, Bruce Richardson: > The size and mask fields are duplicated in both the producer and > consumer data structures. Move them out of that into the top level > structure so they are not duplicated. > > Signed-off-by: Bruce Richardson > Acked-by: Olivier Matz Sorry Bruce, I encounter this error: fatal error: no member named 'size' in 'struct rte_ring_headtail' if (r->prod.size >= ring_size) { ~~~~~~~ ^