From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCHv3] mempool: fix pages computation to determine number of objects Date: Fri, 29 May 2015 17:58:28 +0200 Message-ID: <2481789.3NrDQ1EcU4@xps13> References: <1432571266-25840-2-git-send-email-adrien.mazarguil@6wind.com> <1432716005-21290-1-git-send-email-konstantin.ananyev@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Konstantin Ananyev Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 97AECBE7C for ; Fri, 29 May 2015 20:41:34 +0200 (CEST) Received: by wifw1 with SMTP id w1so34672348wif.0 for ; Fri, 29 May 2015 11:41:34 -0700 (PDT) In-Reply-To: <1432716005-21290-1-git-send-email-konstantin.ananyev@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-05-27 09:40, Konstantin Ananyev: > v3: > - Fixed typo in the commit message. > > v2: > - As suggested in comments use slightly different approach for the fix. > > In rte_mempool_obj_iter(), when element boundary coincides with page boundary, > even if a single page is required per object, a loop checks that the next page > is contiguous and drops the first one otherwise. > This commit checks subsequent pages only when several are required per object. > > Signed-off-by: Konstantin Ananyev Applied, thanks