From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] eal: add config option to enable asserts Date: Mon, 09 Oct 2017 23:01:35 +0200 Message-ID: <2483187.uH7VH6KlI1@xps> References: <20170823140008.184627-1-xuemingl@mellanox.com> <20170824082310.87485-1-xuemingl@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Gaetan Rivet , Wiles Keith To: Xueming Li Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 627151B221 for ; Mon, 9 Oct 2017 23:01:37 +0200 (CEST) In-Reply-To: <20170824082310.87485-1-xuemingl@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/08/2017 10:23, Xueming Li: > Currently, enabling assertion have to set CONFIG_RTE_LOG_LEVEL to > RTE_LOG_DEBUG. CONFIG_RTE_LOG_LEVEL is the default log level of control > path, RTE_LOG_DP_LEVEL is the log level of data path. It's a little bit > hard to understand literally that assertion is decided by control path > LOG_LEVEL, especially assertion used on data path. > > On the other hand, DPDK need an assertion enabling switch w/o impacting > log output level, assuming "--log-level" not specified. > > Assertion is an important API to balance DPDK high performance and > robustness. To promote assertion usage, it's valuable to unhide > assertion out of COFNIG_RTE_LOG_LEVEL. > > In one word, log is log, assertion is assertion, debug is hot pot :) > > Rationale of this patch is to introduce an dedicate switch of > assertion: RTE_ENABLE_ASSERT > > Signed-off-by: Xueming Li > Acked-by: Gaetan Rivet Applied, thanks