From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH 2/2] net/virtio: fix lgtm static checker complaint Date: Thu, 28 Mar 2019 12:04:37 +0100 Message-ID: <24a20bda-5c84-21df-53b5-7c1a811a9eb0@redhat.com> References: <20190327210843.13813-1-stephen@networkplumber.org> <20190327210843.13813-3-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Stephen Hemminger , tiwei.bie@intel.com, zhihong.wang@intel.com Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 671401B11C for ; Thu, 28 Mar 2019 12:04:46 +0100 (CET) In-Reply-To: <20190327210843.13813-3-stephen@networkplumber.org> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/27/19 10:08 PM, Stephen Hemminger wrote: > Since previous test is for mtu < 1519 the next else if > is always true. This causes the lgtm static tool to complain. > Not a real issue, just cosmetic. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/virtio/virtio_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c > index 5f6796bdba37..268fe3b8f156 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -1110,7 +1110,7 @@ virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf) > stats->size_bins[0]++; > else if (s < 1519) > stats->size_bins[6]++; > - else if (s >= 1519) > + else > stats->size_bins[7]++; > } > > Reviewed-by: Maxime Coquelin