Re: [EXTERNAL] [PATCH v7 2/2] test/crypto: add tests for 256-NxA4/5/6 algorithms

[Radu Nicolau <radu.nicolau@intel.com>]

Hi Nithinsen,

Updated as requested, can you please review and ack it?

On 30-Jan-26 11:12 AM, Nithinsen Kaithakadan wrote:
> Hi Radu,
>
> Just a minor comment. Otherwise the changes looks good.
>
> Regards,
> Nithin Sen
>
>> +		return TEST_SKIPPED;
>> +	}
>> +
>> +	return 0;
>> +}
> [Nithinsen] Here functions are not separated by line space. Same applicable between nea_testsuite_setup, nia_testsuite_setup, nca_testsuite_setup
>
>> +static int
>> +nea_testsuite_setup(void)
>> +{
>> +	return nxan_testsuite_setup(RTE_CRYPTO_SYM_XFORM_CIPHER);
>> +}
>> +static int
>> +nia_testsuite_setup(void)
>> +{
>> +	return nxan_testsuite_setup(RTE_CRYPTO_SYM_XFORM_AUTH);
>> +}
>> +static int
>> +nca_testsuite_setup(void)
>> +{
>> +	return nxan_testsuite_setup(RTE_CRYPTO_SYM_XFORM_AEAD);
>> +}
>> +
>> +static int
>> +test_NEA_helper(
>> +	const struct nxa_256_test_data *tdata,
>> +	enum rte_crypto_cipher_operation op)