From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] devtools: add long lines to the list of options Date: Mon, 06 Mar 2017 16:03:37 +0100 Message-ID: <2505793.pX2btbRxNH@xps13> References: <1488390259-40462-1-git-send-email-allain.legacy@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Allain Legacy Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 3AE6B952 for ; Mon, 6 Mar 2017 16:03:39 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id t193so66886558wmt.1 for ; Mon, 06 Mar 2017 07:03:39 -0800 (PST) In-Reply-To: <1488390259-40462-1-git-send-email-allain.legacy@windriver.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-01 12:44, Allain Legacy: > The checkpatch.pl tool is flagging warnings on long debug log strings. > Since splitting these strings makes it difficult to search for logs it is > preferred to allow these as exceptions to the long line rule. The addition > of the LONG_LINE_STRINGS to the list of exceptions will allow lines that > end with a string to exceed the maximum line length, but lines that end > with variables or other constructs will still be flagged as errors. Also, > lines that make use of PRIx64 with string concatenation will still be > flagged if the beginning of the last string fragment begins after the 80 > character threshold. > > Signed-off-by: Allain Legacy [...] > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -45,7 +45,7 @@ options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ > VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ > PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ > SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > -NEW_TYPEDEFS,COMPARISON_TO_NULL" > +NEW_TYPEDEFS,COMPARISON_TO_NULL,LONG_LINE_STRING" Applied and gathered LONG_LINE_STRING and SPLIT_STRING on the same line. Thanks