From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH v3] bus/pci: fix unexpected resource mapping override Date: Wed, 31 Oct 2018 19:30:05 +0100 Message-ID: <2510930.zaILCgKxQ4@xps> References: <20180903084005.29706-1-qi.z.zhang@intel.com> <20181030152720.3728-1-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: stable@dpdk.org, dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com, geoffrey.lv@gmail.com, ajit.khaparde@broadcom.com To: Qi Zhang Return-path: In-Reply-To: <20181030152720.3728-1-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Qi, 30/10/2018 16:27, Qi Zhang: > When scanning an already plugged device, the virtual address > of mapped PCI resource in rte_pci_device will be overridden > with 0, that may cause driver does not work correctly. > The fix is not to update any rte_pci_device's field if the being > scanned device's driver is already probed. > > Bugzilla ID: 85 > Fixes: c752998b5e2e ("pci: introduce library and driver") > Cc: stable@dpdk.org > > Reported-by: Lv Geoffrey > Signed-off-by: Qi Zhang > --- > drivers/bus/pci/linux/pci.c | 35 ++++++++++++++++++++++++++++++----- > 1 file changed, 30 insertions(+), 5 deletions(-) When sending a new version, please use --in-reply-to, and add a changelog somewhere. Applied, thanks