From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 0/2] remove registers for early hardware only Date: Wed, 29 Oct 2014 23:59:34 +0100 Message-ID: <2514313.2vx3aNJpxn@xps13> References: <1414044079-10006-1-git-send-email-helin.zhang@intel.com> <1414566571-25829-1-git-send-email-helin.zhang@intel.com> <9BB6961774997848B5B42BEC655768F8B25561@SHSMSX104.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Zhang, Helin" Return-path: In-Reply-To: <9BB6961774997848B5B42BEC655768F8B25561-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-29 08:53, Wu, Jingjing: > From: Zhang, Helin > > For those registers and their relevant for early hardware only, they should > > neither be defined nor be used. Thus i40e_register_x710_int.h should be > > removed. As I40E_GLINT_CTL and its relevant is really needed, just define it > > directly as a workaround. > > > > v2 changes: > > * Added back writing I40E_GLINT_CTL with correct configurations, > > as it is really needed. Otherwise there would be problem of > > single descriptor write back. > > * Removed those code style fix, as it is already in another > > patch set. > > > > Helin Zhang (2): > > i40e: do not use macros defined in i40e_register_x710_int.h > > i40e: remove i40e_register_x710_int.h > > > > lib/librte_pmd_i40e/i40e/i40e_register_x710_int.h | 10712 -------------------- > > lib/librte_pmd_i40e/i40e_ethdev.c | 5 +- > > 2 files changed, 4 insertions(+), 10713 deletions(-) delete mode 100644 > > Acked-by: Jingjing Wu Applied in one patch: i40e/base: remove early hardware definitions Thanks -- Thomas