dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org,
	fbl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] vhost: Add -lfuse into the LDFLAGS list
Date: Mon, 26 Jan 2015 22:03:58 +0100	[thread overview]
Message-ID: <2515628.0MMkDe1ao4@xps13> (raw)
In-Reply-To: <1421786998-5814-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>

2015-01-20 15:49, Neil Horman:
> the vhost library relies on libfuse, and thats included when we do a normal
> shared object build, but when we specify combined libs, its gets left out.  Add
> it back in
> 
> Signed-off-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
> ---
>  mk/rte.app.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> +ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)
> +LDLIBS += -lfuse
> +endif

There was already a line for -lfuse below in the file.
You are adding it in a place where it applies to every cases,
so you should remove the old special case.

Thanks
-- 
Thomas

  parent reply	other threads:[~2015-01-26 21:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 20:49 [PATCH] vhost: Add -lfuse into the LDFLAGS list Neil Horman
     [not found] ` <1421786998-5814-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2015-01-20 22:24   ` Flavio Leitner
2015-01-26 21:03   ` Thomas Monjalon [this message]
2015-01-27 14:39   ` [PATCH v2] " Neil Horman
     [not found]     ` <1422369594-25960-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2015-01-27 16:02       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2515628.0MMkDe1ao4@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=fbl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).