From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] bus/pci: fix missing case for virtio-crypto
Date: Fri, 02 Nov 2018 11:39:37 +0100
Message-ID: <2529427.7ESO8GYSS3@xps>
References: <20181101121009.86287-1-roy.fan.zhang@intel.com>
 <2772595.iFPTlCQAWG@xps>
 <9F7182E3F746AB4EA17801C148F3C604334D4B41@IRSMSX101.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "alejandro.lucero@netronome.com" <alejandro.lucero@netronome.com>,
 bruce.richardson@intel.com, ferruh.yigit@intel.com
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id EE0761B21A
 for <dev@dpdk.org>; Fri,  2 Nov 2018 11:39:40 +0100 (CET)
In-Reply-To: <9F7182E3F746AB4EA17801C148F3C604334D4B41@IRSMSX101.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

+Cc Bruce and Ferruh

02/11/2018 11:01, Zhang, Roy Fan:
> Hi Thomas,
> 
> You are right, the problem can happen with any PMD falls into RTE_KDRV_UIO_GENERIC and RTE_KDRV_NIC_UIO driver type. As riginally rte_pci_read_config() only covered 2 out of 4 possible driver types' .
> 
> The patch was submitted for fixing the Virtio Crypto Initialization Segmentation Fault problem introduced in 18.11 RC1, and it did. The problem is I don't think the patch will fix all problems of rte_pci_read_config(). Even I added RTE_KDRV_UIO_GENERIC type into the switch case there is a remaining RTE_KDRV_NIC_UIO type I am not sure where to fit due to the limited knowledge.
> 
> That's why I write the patch title like this. I hope someone else with better bus knowledge could submit a complete fix patch.
> 
> Best regards,
> Fan
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Thursday, November 1, 2018 1:35 PM
> > To: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> > Cc: dev@dpdk.org; alejandro.lucero@netronome.com
> > Subject: Re: [PATCH] bus/pci: fix missing case for virtio-crypto
> > 
> > 01/11/2018 13:10, Fan Zhang:
> > > The recent change to rte_pci_read_config() caused virtio-crypto device
> > > initialization always failed as it has a RTE_KDRV_UIO_GENERIC driver
> > > type. This patch fixes the problem.
> > 
> > Hi Fan,
> > this issue is not related at all to virtio-crypto.
> > It can happen with any PMD, right?
> > 
> > In the title, we should mention UIO generic driver.
> > 
> > 
>