From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C3ECC43603 for ; Tue, 10 Dec 2019 22:46:29 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id CEC402077B for ; Tue, 10 Dec 2019 22:46:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="YOKsdD4x"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="wDl6CW2W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEC402077B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E629637A2; Tue, 10 Dec 2019 23:46:27 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id E88E723D for ; Tue, 10 Dec 2019 23:46:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4C1C5EBA; Tue, 10 Dec 2019 17:46:23 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 10 Dec 2019 17:46:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=WFatoV0xvVANpafjEjBUn0D6tlayq3ko0s3mJ1KVSFk=; b=YOKsdD4xTmQB krt1kUwCVrL8AM6GtNywjs3CUPFVtNoaPEgFsO9ujFftsfXszM9KrOidoNf7HciW eDhSbuuSGsDd2TRMgmG6XBNtDoQbpcNeJwRsrMsqFqzhyed4WdSCW8vf4pt0GOdB 6nwuljxVHNSyZ1hCD63VStOiGpNL1DI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=WFatoV0xvVANpafjEjBUn0D6tlayq3ko0s3mJ1KVS Fk=; b=wDl6CW2WBUiobc6aa5m+Afrl+kZIwxv3Vmn46pMW99vUP0kJ3QGpNJdxX 8kYirL5l93mHwu6ciO7Hy6Lxx30sUhaTkJXJanPzGngXR6HmeDo6nIYH7BPpJHo6 ge3uwLM2HEJBqsFWpDidt5uBiAb97ao18qXbsPEAFYAfhtMFSrqnn5A1yYNGqRfh 00cLIVqRBqzOYQGtieWtoVxh8iVKXe2lbgHDIGm7LevPHvlAFRge+Uhi+fuOjGb/ LwMePOhnqQRe5WIF9ImFElRycUU0vUWI/Ctq8dcHJLY5suLJuh0RYuFh21SvuStu VYs3ImgZlgMW+psSKFt1YimMouSGA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudelfedgudeigecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtuf ertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenuc frrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthen ucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BE94730600DC; Tue, 10 Dec 2019 17:46:21 -0500 (EST) From: Thomas Monjalon To: jerinj@marvell.com Cc: dev@dpdk.org, david.marchand@redhat.com, Adrien Mazarguil Date: Tue, 10 Dec 2019 23:46:20 +0100 Message-ID: <2530549.bTtaOq4tWD@xps> In-Reply-To: <20191208113413.2179329-1-jerinj@marvell.com> References: <20191208113413.2179329-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/3] eal: introduce structure marker typedefs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/12/2019 12:34, jerinj@marvell.com: > From: Jerin Jacob > > Introduce EAL typedef for structure 1B, 2B, 4B, 8B alignment marking and > a generic marker for a point in a structure. > > Signed-off-by: Jerin Jacob > --- > lib/librte_eal/common/include/rte_common.h | 12 ++++++++++++ Good idea, thanks. > +/** Generic marker for a point in a structure. */ I think "a point" may be replaced with "any place" or something else? > +__extension__ typedef void *RTE_MARKER[0]; Why do we need an extension? If it is part of C11, we should use RTE_STD_C11 instead. If it is another reason, we could create another meaningful EAL macro.