From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [memnic PATCH 13/16] pmd: rename doc when installing
Date: Thu, 27 Mar 2014 11:29:40 +0100
Message-ID: <2538842.0sWbMQBLAx@xps13>
References: <1391529271-24606-1-git-send-email-thomas.monjalon@6wind.com>
 <1391529271-24606-14-git-send-email-thomas.monjalon@6wind.com>
 <5333E2F3.6060503@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <5333E2F3.6060503-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

> > MEMNIC doc may be installed with other DPDK docs.
> > So more descriptive naming is required.
> > 
> > A rule is created in order to have the same rule style for lib and doc.
> > 
> > Signed-off-by: Thomas Monjalon<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> 
>   [...]
> 
> > +$(DESTDIR)$(docdir)/$(DOC) : $S/README.rst
> > +	install -D -m 644 $< $@
> 
> What about renaming README.rst in dpdk-memnic.rst in source ?

I'm not convinced. README is a good name when looking in source tree.

> The rest of the patch looks good to me.
> 
> Reviewed-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Applied

-- 
Thomas