From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: fix statistics description Date: Tue, 04 Oct 2016 11:34:33 +0200 Message-ID: <2544827.v0ahXV4zxG@xps13> References: <1472206104-22035-1-git-send-email-wei.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Wei Dai , john.mcnamara@intel.com Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 15D5868CA for ; Tue, 4 Oct 2016 11:34:51 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id p138so200679648wmb.1 for ; Tue, 04 Oct 2016 02:34:51 -0700 (PDT) In-Reply-To: <1472206104-22035-1-git-send-email-wei.dai@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-08-26 18:08, Wei Dai: > /** > * A structure used to retrieve statistics for an Ethernet port. > + * Not all statistics fields in struct rte_eth_stats are supported > + * by any type of network interface card (NIC). If any statistics > + * field is not supported, its value is 0 . > */ > struct rte_eth_stats { I'm missing the point of this patch. Why do you think it is a fix? John, any opinion?