From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v11 2/8] ethdev: use constants for link duplex
Date: Wed, 23 Mar 2016 09:34:35 +0100
Message-ID: <2545468.xWxNWWbLOO@xps13>
References: <1457992546-32230-1-git-send-email-thomas.monjalon@6wind.com>
 <1458238145-7496-3-git-send-email-thomas.monjalon@6wind.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A9D0078@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "marcdevel@gmail.com" <marcdevel@gmail.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, "Doherty,
 Declan" <declan.doherty@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Lu,
 Wenzhuo" <wenzhuo.lu@intel.com>, dev@dpdk.org
To: "Zhang, Helin" <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 85D092BA2
 for <dev@dpdk.org>; Wed, 23 Mar 2016 09:36:30 +0100 (CET)
Received: by mail-wm0-f48.google.com with SMTP id l68so223359348wml.0
 for <dev@dpdk.org>; Wed, 23 Mar 2016 01:36:30 -0700 (PDT)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A9D0078@SHSMSX104.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-23 02:44, Zhang, Helin:
> >  struct rte_eth_link {
> >       uint16_t link_speed;      /**< ETH_LINK_SPEED_[10, 100, 1000, 10000]
> > */
> > -     uint16_t link_duplex;     /**< ETH_LINK_[HALF_DUPLEX,
> > FULL_DUPLEX] */
> > +     uint16_t link_duplex;     /**< ETH_LINK_[HALF/FULL]_DUPLEX */
> >       uint8_t  link_status : 1; /**< ETH_LINK_[DOWN/UP] */
> >  }__attribute__((aligned(8)));     /**< aligned for atomic64 read/write */
> For link speed and link duplex, I'd suggest to add one more status of 'UNKNOWN'.
> Because, sometimes it cannot get all the information from hardware.
> For link stauts, assume it in DOWN state is acceptable, while for other two, I don't think so.
> 
> Currently it can be seen that a default link speed and duplex will be set if it cannot
> get the accurate info from hardware. That's not good, and I think UNKNOWN could be better.
> 
> What do you think?

OK, please provide a patch on top of this one to set ETH_LINK_UNKNOWN_DUPLEX
in the drivers where appropriate.