From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] devtools: add compressdev tests to test-build
Date: Mon, 16 Jul 2018 21:50:53 +0200
Message-ID: <2549532.10hGl2W0VU@xps>
References: <20180711071750.9872-1-pablo.de.lara.guarch@intel.com>
 <1571428.5RkRqaR3OR@xps>
 <E115CCD9D858EF4F90C690B0DCB4D8977F8FBE1B@IRSMSX107.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com
 [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 4155F16E
 for <dev@dpdk.org>; Mon, 16 Jul 2018 21:50:59 +0200 (CEST)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8977F8FBE1B@IRSMSX107.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

16/07/2018 19:33, De Lara Guarch, Pablo:
> HI Thomas,
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Wednesday, July 11, 2018 4:50 PM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [PATCH] devtools: add compressdev tests to test-build
> > 
> > 11/07/2018 09:17, Pablo de Lara:
> > > Compressdev tests depend on Zlib library, so they can only be enabled
> > > if this is available.
> > >
> > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > > ---
> > > --- a/devtools/test-build.sh
> > > +++ b/devtools/test-build.sh
> > > @@ -154,6 +154,7 @@ config () # <directory> <target> <options>
> > >  		test "$DPDK_DEP_ZLIB" != y || \
> > >  		sed -ri          's,(BNX2X_PMD=)n,\1y,' $1/.config
> > >  		sed -ri            's,(NFP_PMD=)n,\1y,' $1/.config
> > > +		sed -ri   's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config
> > 
> > It is always enabled here.
> > You need to repeat the ZLIB condition for NFP and COMPRESSDEV_TEST.
> > 
> 
> I see. So, does this mean that NFP PMD is always enabled? Do we need a fix for that?

Exact