From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 08/11] eal: pci: introduce RTE_KDRV_VFIO_NOIOMMUi driver mode Date: Wed, 27 Jan 2016 16:39:23 +0100 Message-ID: <25509182.RtDY3IvNbk@xps13> References: <1453229842-15310-1-git-send-email-sshukla@mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Michael S. Tsirkin" , dev@dpdk.org, Alex Williamson To: Santosh Shukla Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 9479B95CA for ; Wed, 27 Jan 2016 16:40:34 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id n5so32489034wmn.0 for ; Wed, 27 Jan 2016 07:40:34 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-01-27 21:02, Santosh Shukla: > 1. virtio currently works for vfio+noiommu and likely will work for > vfio+iommu in near future. > 2. So remove __noiommu suffix and always use default. > 3. Introduce vfio resource parsing global function, That function > suppose to do parsing for default vfio case and for vfio-noiommu case. > This function will be used by pmd drivers for resource parsing purpose > example virtio. > > Yuan won't be happy with 3) I guess, because he wanted to get rid of > interface parsing from pmd driver. > > Thomas, if 1/2/3/ addresses your concern then I'll spin the series, I agree with 1/ and 2/. Please, could you explain why 3/ is needed?