From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 00/41] Introduce NXP DPAA Bus, Mempool and PMD Date: Fri, 22 Sep 2017 00:10:53 +0200 Message-ID: <25531756.sobbYYJFMz@xps> References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, ferruh.yigit@intel.com, hemant.agrawal@nxp.com To: Shreyansh Jain Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0135E7CFD for ; Fri, 22 Sep 2017 00:10:54 +0200 (CEST) In-Reply-To: <20170909112132.13936-1-shreyansh.jain@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/09/2017 13:20, Shreyansh Jain: > DPAA, or Datapath Acceleration Architecture [R2], is a set of hardware > components designed for high-speed network packet processing. This > architecture provides the infrastructure to support simplified sharing of > networking interfaces and accelerators by multiple CPU cores, and the > accelerators themselves. > > This patchset introduces the following: > 1. DPAA Bus (drivers/bus/dpaa) > The core of DPAA bus is implemented using 3 main hardware blocks: QMan, > or Queue Manager; BMan, or Buffer Manager and FMan, or Frame Manager. > The patches introduce necessary layers to expose the DPAA hardware > blocks for interfacing with RTE framework. I guess these are the same blocks as for DPAA2? They are in drivers/bus/fslmc/ Why introducing yet another bus driver? The fslmc one was supposed to cover any Freescale (NXP (Qualcomm)) SoC. > 2. DPAA Mempool (drivers/mempool/dpaa) > BMan, or Buffer Manager, block of DPAA features a hardware offloaded > mempool. These patches add support for a driver to manage the BMan > block. This driver allows for mempool creation, deletion, buffer > acquire and release, as per the RTE APIs. > > 3. DPAA PMD (drivers/net/dpaa) > The Poll Mode Driver for DPAA NIC Interfaces. > > Patch Layout > ============ > > 01: Add DPAA SoC build configuration > 02~16: Add DPAA Bus support and features, incrementally > 17: Add Documentation > 18~21: Add DPAA Mempool support > 22~41: Add PMD and its various features, incrementally It is a very long series introducing 3 different subsystems. I think everybody was scared about reviewing it. Why you did not split it?