From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL Date: Tue, 11 Oct 2016 15:57:29 +0200 Message-ID: <2554688.6PDizipyct@xps13> References: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> <20161011133824.GA31866@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Shreyansh Jain , "david.marchand@6wind.com" , dev@dpdk.org To: Neil Horman Return-path: Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) by dpdk.org (Postfix) with ESMTP id A18DC2BA6 for ; Tue, 11 Oct 2016 15:57:31 +0200 (CEST) Received: by mail-lf0-f44.google.com with SMTP id l131so10112782lfl.2 for ; Tue, 11 Oct 2016 06:57:31 -0700 (PDT) In-Reply-To: <20161011133824.GA31866@hmsreliant.think-freely.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-10-11 09:38, Neil Horman: > This also begs the question in my mind, is it really worth changing the macro? > I really don't think it is. The registration macros are pretty descriptive as > they stand, and have already changed 3 or 4 times in the last 6 months, which > suggests to me that any change here is really just churn more than meaningful > change. You can make the argument that the name might be more in line with the > library its implemented in or what not, but in truth, its easy to understand > what the macros do (in their previous or current incantations), and any change > that just makes them the same as other macros in their naming is really more > trouble than its worth. Neil, the long term goal is to stop having some identifiers which do not start with RTE_ in our exported .h files. I think it is a reasonable policy, for a library, to live in a well defined namespace.