From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1 0/5] clean-up cpuflags Date: Wed, 03 Feb 2016 15:01:26 +0100 Message-ID: <2567498.ifnkeR5xCN@xps13> References: <1454453993-3903-1-git-send-email-thomas.monjalon@6wind.com> <20160203133810.GA7359@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, viktorin@rehivetech.com To: Jerin Jacob Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id D2B3F8D90 for ; Wed, 3 Feb 2016 15:02:39 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id l66so71798140wml.0 for ; Wed, 03 Feb 2016 06:02:39 -0800 (PST) In-Reply-To: <20160203133810.GA7359@localhost.localdomain> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-02-03 19:08, Jerin Jacob: > On Tue, Feb 02, 2016 at 11:59:48PM +0100, Thomas Monjalon wrote: > > Following the work of Ferruh, I suggest this cleanup to remove as much > > as possible of the code from the cpuflags headers. > > The goal is to un-inline these functions (not performance sensitive) > > and remove the CPU flags table from the ABI (just added recently). > > The bonus is to stop mimic x86 in ARM and PPC implementations. > > > > WARNING: it has not been tested nor compiled on Tilera, ARM and POWER8. > > Please help, thank you. > > compilation errors on arm64 too. Yes I forgot REG_PLATFORM. > arm64 toolchains are publicly available @ > http://releases.linaro.org/14.11/components/toolchain/binaries/aarch64-linux-gnu/ Yes I know, thank you. I will test and make a v2. Do you have any comment on the changes?