From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 08/24] rte_ring_generic.h: stack
	declarations before code
Date: Mon, 14 May 2018 03:49:52 +0200
Message-ID: <2579149.bEE7AC6OuP@xps>
References: <152609021699.121661.5295227351721865436.stgit@localhost.localdomain>
 <1896621.ibENEg8Kdi@xps> <a1dcffd5-ca16-d5f4-66c5-6091d9fa215c@warmcat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bruce.richardson@intel.com, olivier.matz@6wind.com
To: Andy Green <andy@warmcat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 398271C185
 for <dev@dpdk.org>; Mon, 14 May 2018 03:49:55 +0200 (CEST)
In-Reply-To: <a1dcffd5-ca16-d5f4-66c5-6091d9fa215c@warmcat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/05/2018 02:09, Andy Green:
> 
> On 05/14/2018 07:44 AM, Thomas Monjalon wrote:
> > 14/05/2018 01:21, Andy Green:
> >>
> >> On 05/14/2018 12:47 AM, Thomas Monjalon wrote:
> >>> 12/05/2018 03:59, Andy Green:
> >>>> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:
> >>>> In function '__rte_ring_move_prod_head':
> >>>> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3:
> >>>> warning: ISO C90 forbids mixed declarations and code
> >>>> [-Wdeclaration-after-statement]
> >>>>      const uint32_t cons_tail = r->cons.tail;
> >>>>      ^~~~~
> >>>> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:
> >>>> In function '__rte_ring_move_cons_head':
> >>>> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:147:3:
> >>>> warning: ISO C90 forbids mixed declarations and code
> >>>> [-Wdeclaration-after-statement]
> >>>>      const uint32_t prod_tail = r->prod.tail;
> >>>
> >>> The fix line is:
> >>> Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation")
> >>
> >> OK... people can just use git blame at the time they want to know this
> >> though.
> > 
> > No, we need it to automatically detect which commits should be backported,
> 
> There is nothing automatic about that flow :-)
> 
> It's "automatic after every committer did the work manually" you mean.

Yes.
In this case, I found it for you.
You just need to keep it if doing a new revision.

> > and in which branch.
> > 
> > We also add Cc: stable@dpdk.org to confirm explicitly that is must be backported.
> 
> In other projects this work falls on the maintainer(s).

In DPDK too, the maintainers often fill this field
(I did it for your 8 patches just pushed today).
But we prefer when this work is done by the patch author :)